Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Sep 24, 2017

Fixes #6170

If your carddav data grows this significantly improves the query speed. We are probabaly missing more. But this is a start.

CC: @tcitworld

@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #6631 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6631      +/-   ##
============================================
+ Coverage     53.06%   53.06%   +<.01%     
- Complexity    22553    22554       +1     
============================================
  Files          1414     1415       +1     
  Lines         87745    87751       +6     
  Branches       1340     1340              
============================================
+ Hits          46560    46565       +5     
- Misses        41185    41186       +1
Impacted Files Coverage Δ Complexity Δ
...av/lib/Migration/Version1004Date20170924124212.php 0% <0%> (ø) 1 <1> (?)
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️

@MorrisJobke
Copy link
Member

None of the indices were added: 😢

bildschirmfoto 2017-09-25 um 09 57 48

@rullzer
Copy link
Member Author

rullzer commented Sep 25, 2017

mmmm indeed... Let me debug...

Fixes #6170

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Sep 25, 2017

Ok fixed... should work now...

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works now 👍

@MorrisJobke MorrisJobke merged commit 4677af1 into master Sep 25, 2017
@MorrisJobke MorrisJobke deleted the fix_6170 branch September 25, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants