Make OC\Security\RateLimiting strict #7852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
LukasReschke,
MorrisJobke,
juliusknorr and
nickvergessen
rullzer
force-pushed
the
strict_ratelimiting
branch
from
522fa49 to
ca52e48
Compare
Codecov Report
@@ Coverage Diff @@
## master #7852 +/- ##
=========================================
Coverage ? 51.21%
Complexity ? 24957
=========================================
Files ? 1607
Lines ? 95049
Branches ? 1376
=========================================
Hits ? 48676
Misses ? 46373
Partials ? 0
|
ChristophWurst
approved these changes
Jan 14, 2018
* Add return types * Add scalar argument types * Made strict * Cleaned up phpstorm inspections Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
strict_ratelimiting
branch
from
ca52e48 to
cf0a339
Compare
MorrisJobke
approved these changes
Jan 14, 2018
Member
|
Ref #7392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl