Fix gallery buttons selector #8936
Conversation
skjnldsv
added
design
| } | ||
|
|
||
| #controls { | ||
| #controls .actions { |
There was a problem hiding this comment.
.actions is also used by the files app "add" button and causes it to be not square anymore.
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Naive question, but would not removing > from > .button, button {, without touching anything else in the server nor in the gallery, fix the problem? I mean, why are those rules applied only to direct children instead of descendants (like they were before 966ceca)?
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-gallery-selectors
branch
from
fc5c0f1 to
25ea0e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #8936 +/- ##
=========================================
Coverage ? 51.79%
Complexity ? 25332
=========================================
Files ? 1603
Lines ? 95197
Branches ? 1388
=========================================
Hits ? 49304
Misses ? 45893
Partials ? 0 |
|
@danxuliu the issue with the control bar is we have a lot of plugins registering their buttons here, and it's absolutely not standardised. So having a popovermenu here was conflicting with this rule, that's why I added the direct child selector to avoid the selector to go down the entire dom structure :) |
Fix nextcloud/gallery#413
With nextcloud/gallery#414
@nextcloud/designers