Fix style of password button on protected link shares #9768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
design
Codecov Report
@@ Coverage Diff @@
## master #9768 +/- ##
============================================
- Coverage 51.95% 51.95% -0.01%
Complexity 25756 25756
============================================
Files 1634 1634
Lines 95385 95385
Branches 1308 1308
============================================
- Hits 49554 49553 -1
- Misses 45831 45832 +1
|
Member
|
For Login (and two factor) we re-introduced a dedicated button. I think this would be a nice idea here too, since this page is often used by people which were never in contact with the Nextcloud UI in the past ... What do you think? Worth open an issue for? @nextcloud/designers |
Member
Author
|
Sounds useful. Also we don’t need to save on space here |
Member
|
Yup, separate button below would be fine here, also might look more balanced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nextcloud/designers
Before:
After:
The little key is from my browser ;)