Skip to content

feat(conversations): Follow up for event conversation handling#14713

Merged
nickvergessen merged 1 commit intomainfrom
feat/14689/event-conversation-followup-api
Apr 8, 2025
Merged

feat(conversations): Follow up for event conversation handling#14713
nickvergessen merged 1 commit intomainfrom
feat/14689/event-conversation-followup-api

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Mar 24, 2025

β˜‘οΈ Resolves

πŸ› οΈ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@SystemKeeper

This comment was marked as resolved.

@miaulalala miaulalala marked this pull request as ready for review March 26, 2025 15:11
@miaulalala miaulalala added 3. to review feature: api πŸ› οΈ OCS API for conversations, chats and participants and removed 2. developing labels Mar 26, 2025
Copy link
Copy Markdown
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine for me. Test cases:

  • Past event
  • Ongoing event
  • Future event
  • Future future event (start > 16h from now)
  • Editing of title and description and sync to talk
  • Manually copying an existing event room link to another event -> converted to regular room

From the code/test-side nickvergessen should take a look, can't fully judge.

One thing I noticed: Editing title and description is not prevent on API level for event rooms - should we do that?

@miaulalala
Copy link
Copy Markdown
Contributor Author

One thing I noticed: Editing title and description is not prevent on API level for event rooms - should we do that?

Added a 403 for editiing room name and description for event rooms.

Comment thread lib/Controller/RoomController.php Outdated
Comment thread lib/Controller/RoomController.php Outdated
Comment thread lib/Listener/CalDavEventListener.php Outdated
Comment thread lib/Listener/CalDavEventListener.php
Comment thread lib/Listener/CalDavEventListener.php
@miaulalala miaulalala requested a review from nickvergessen April 7, 2025 15:29
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/14689/event-conversation-followup-api branch from 33fbec7 to 4dbedb8 Compare April 7, 2025 15:39
@nickvergessen nickvergessen merged commit 349fda5 into main Apr 8, 2025
79 checks passed
@nickvergessen nickvergessen deleted the feat/14689/event-conversation-followup-api branch April 8, 2025 12:13
@nickvergessen
Copy link
Copy Markdown
Member

/backport to stable31

@backportbot
Copy link
Copy Markdown

backportbot Bot commented May 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/14713/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4dbedb8a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14713/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: conversations πŸ‘₯ feature: integration πŸ“¦ Integration with 3rd party (chat) service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ“… Handling of event conversations - βš™οΈ API - Follow up

3 participants