feat(conversations): Follow up for event conversation handling#14713
Merged
nickvergessen merged 1 commit intomainfrom Apr 8, 2025
Merged
feat(conversations): Follow up for event conversation handling#14713nickvergessen merged 1 commit intomainfrom
nickvergessen merged 1 commit intomainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
SystemKeeper
left a comment
There was a problem hiding this comment.
Tested and works fine for me. Test cases:
- Past event
- Ongoing event
- Future event
- Future future event (start > 16h from now)
- Editing of title and description and sync to talk
- Manually copying an existing event room link to another event -> converted to regular room
From the code/test-side nickvergessen should take a look, can't fully judge.
One thing I noticed: Editing title and description is not prevent on API level for event rooms - should we do that?
Contributor
Author
Added a 403 for editiing room name and description for event rooms. |
4 tasks
Signed-off-by: Anna Larch <anna@nextcloud.com>
33fbec7 to
4dbedb8
Compare
nickvergessen
approved these changes
Apr 8, 2025
Member
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/14713/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4dbedb8a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14713/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
βοΈ Resolves
π οΈ API Checklist
π§ Tasks
π Checklist
docs/has been updated or is not required