Skip to content

Fix: hide message expiration settings when not supported by server #16312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Nov 13, 2025
Merged

Fix: hide message expiration settings when not supported by server #16312

Antreesy merged 1 commit into from
Nov 13, 2025

Conversation

@max65482
Copy link
Contributor

@max65482 max65482 commented Nov 12, 2025 •
edited by Antreesy
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Now the message expiration setting is not offered if it's not supported by the server.

Is this something you would expect in the documentation?

@max65482
fix: hide message expiration settings when not supported by server
8bbb26d 
Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
@Antreesy
Copy link
Contributor

Antreesy commented Nov 13, 2025

Thanks, we'll take a look at this

Is this something you would expect in the documentation?

That expiration isn't available without cron jobs? Not in the user documentation, I'd say

Antreesy
Antreesy approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, thanks for implementation!

@Antreesy Antreesy added 3. to review feature: settings ⚙️ Settings and config related issues feature: frontend 🖌️ "Web UI" client labels Nov 13, 2025
@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Nov 13, 2025
@Antreesy
Copy link
Contributor

Antreesy commented Nov 13, 2025

/backport to stable32

@Antreesy
Copy link
Contributor

Antreesy commented Nov 13, 2025

/backport to stable31

@Antreesy Antreesy merged commit e1fc8da into nextcloud:main Nov 13, 2025
56 checks passed
This was referenced Nov 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

No one assigned

Labels

3. to review feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

Message expiration is not hidden when not supported by the server

2 participants

@max65482 @Antreesy