Skip to content

fix: move expensive capabilities check from URL generation service #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Nov 28, 2025
Merged

fix: move expensive capabilities check from URL generation service #16418

Antreesy merged 1 commit into from
Nov 28, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 26, 2025

☑️ Resolves

  • Fix problem that doesn't exist yet Talk plugins compiled size
  • conversationsService is pulling CapabilitiesManager <- useTalkHashStore <- pinia library and some other utils
  • caused by makeConversationPublic(), which is used in a single store and can be checked there

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

talk-floating-call is WIP, but it reveals an issue
Not noticed in another plugins, since they already including pinia from other sources

🏚️ Before 🏡 After
image image

🚧 Tasks

  • checked files sidebars and deck integration, no effect on size for any existing plugin

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Nov 26, 2025
@Antreesy Antreesy requested a review from DorraJaouad November 26, 2025 17:11
@Antreesy Antreesy self-assigned this Nov 26, 2025
DorraJaouad
DorraJaouad approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just lint it

@Antreesy
fix: move expensive capabilities check from URL generation service
b9d9fd5 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/reduce-plugin-entries branch from 457f1fb to b9d9fd5 Compare November 28, 2025 10:19
@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 28, 2025

/backport to stable32

@Antreesy Antreesy merged commit a4d61db into main Nov 28, 2025
56 checks passed
@Antreesy Antreesy deleted the fix/noid/reduce-plugin-entries branch November 28, 2025 10:49
@backportbot backportbot bot mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review feature: frontend 🖌️ "Web UI" client technical debt

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad