Skip to content

fix(VideoVue): do not rely on participant permissions #16542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 2 commits into from
Dec 12, 2025
Merged

fix(VideoVue): do not rely on participant permissions #16542

Antreesy merged 2 commits into from
Dec 12, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 12, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
fix(VideoVue): do not rely on participant permissions
3a05741 
- guests do not have access to participant object. Workaround would be to get permissions from signaling users - but `videoAvailable` and `videoBlocked` should already be enough

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(webrtc): improve code readability
4f2018c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Dec 12, 2025
@Antreesy Antreesy self-assigned this Dec 12, 2025
danxuliu
danxuliu approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 12, 2025

/backport to stable32

@Antreesy Antreesy merged commit 6f27c0f into main Dec 12, 2025
56 of 57 checks passed
@Antreesy Antreesy deleted the fix/16517/media-disabled branch December 12, 2025 17:32
@backportbot backportbot bot mentioned this pull request Dec 12, 2025
Merged
@danxuliu
Copy link
Member

danxuliu commented Dec 12, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu danxuliu approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: call 📹 Voice and video calls regression

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @danxuliu