Skip to content

fix(CallFailedDialog): expose reload function #16626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Jan 5, 2026
Merged

fix(CallFailedDialog): expose reload function #16626

Antreesy merged 1 commit into from
Jan 5, 2026
+20 −1

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 22, 2025 •
edited
Loading

☑️ Resolves

  • Fix non-intuitive UI when connection failed and user likely needs to reload the page to apply new settings
  • This adds a direct button in the dialog user sees

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2025-12-22_11h49_28 2025-12-22_11h49_07

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Dec 22, 2025
@Antreesy Antreesy requested a review from ShGKme December 22, 2025 11:11
@Antreesy Antreesy self-assigned this Dec 22, 2025
ShGKme
ShGKme reviewed Jan 5, 2026
View reviewed changes
DorraJaouad
DorraJaouad reviewed Jan 5, 2026
View reviewed changes
DorraJaouad
DorraJaouad approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise is GTG, I let the wording discussion off this approval

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 5, 2026

/backport to stable32

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 5, 2026

/backport to stable31

@Antreesy
fix(CallFailedDialog): expose reload function
ede41d0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/call-failed-reload branch from 27d3abe to ede41d0 Compare January 5, 2026 12:29
@Antreesy Antreesy requested a review from ShGKme January 5, 2026 12:30
@Antreesy Antreesy merged commit 16f56cd into main Jan 5, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/noid/call-failed-reload branch January 5, 2026 13:10
This was referenced Jan 5, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review enhancement feature: call 📹 Voice and video calls

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @ShGKme @DorraJaouad