test: pass command as array for occ command in integration tests#16887
Merged
nickvergessen merged 1 commit intomainfrom Jan 28, 2026
Merged
test: pass command as array for occ command in integration tests#16887nickvergessen merged 1 commit intomainfrom
nickvergessen merged 1 commit intomainfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
integration-occ-command-array
branch
from
aeda073 to
38cf50f
Compare
nickvergessen
approved these changes
Jan 28, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Seems to work properly here, also the test that made us add the utf8 handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an unknown reason, passing the command as a string and going trough the extra shell step causes it not to find
phpin my dev setup, event though it's in$PATH.Also saves having to deal with
escapeshellarg