Skip to content

fix: enhance preview coherence in media settings#17071

Merged
DorraJaouad merged 1 commit intomainfrom
fix/noid/call-view-part-2
Feb 12, 2026
Merged

fix: enhance preview coherence in media settings#17071
DorraJaouad merged 1 commit intomainfrom
fix/noid/call-view-part-2

Conversation

@DorraJaouad
Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad commented Feb 12, 2026

☑️ Resolves

I understand that the preview is not on the same darkness/lightness as in call view but the preview is rendered in different theme, so it has to be close to it (e,g if it is light them, it should not be too dark)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🏖️ Next Major (34) milestone Feb 12, 2026
@DorraJaouad DorraJaouad requested a review from Antreesy February 12, 2026 10:22
@DorraJaouad DorraJaouad self-assigned this Feb 12, 2026
@DorraJaouad
Copy link
Copy Markdown
Contributor Author

I will cherry pick the commit and add it to the backport

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good change

Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/call-view-part-2 branch from 4ffe845 to 1e177eb Compare February 12, 2026 10:39
@DorraJaouad DorraJaouad merged commit cf5d8ca into main Feb 12, 2026
55 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/call-view-part-2 branch February 12, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants