fix(SearchPlugin): check search queries for multibyte characters#17132
Merged
nickvergessen merged 3 commits intomainfrom Feb 16, 2026
Merged
fix(SearchPlugin): check search queries for multibyte characters#17132nickvergessen merged 3 commits intomainfrom
nickvergessen merged 3 commits intomainfrom
Conversation
- applicable to chat mentions search + non-latin alphabet with case-insensitive examples Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
bug
feature: api 🛠️
miaulalala
approved these changes
Feb 16, 2026
Contributor
|
Had a quick look, possible candidates are:
There's also some calls to |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Member
|
Let me fix conversation search |
Signed-off-by: Joas Schilling <coding@schilljs.com>
miaulalala
reviewed
Feb 16, 2026
Comment on lines
+126
to
+129
| $result[mb_strtolower($displayName . '#' . $room->getToken())] = $entry; | ||
|
|
||
| if ($query->getCursor() === $room->getToken()) { | ||
| $cursorKey = strtolower($displayName . '#' . $room->getToken()); | ||
| $cursorKey = mb_strtolower($displayName . '#' . $room->getToken()); |
Contributor
There was a problem hiding this comment.
Would only lowercasing the room name work too? Could be considered a tiny performance improvement
miaulalala
approved these changes
Feb 16, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@кирилл|@Кирилл🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required