Fix(signaling): ignore ECONNABORTED errors to prevent conversation not found#17158
Conversation
…t found Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
There was a problem hiding this comment.
Otherwise a good addition. Can reproduce locally with small patch (axios aborts request with this code when timeout, and in other cases) + Internal signaling
--- a/src/services/signalingService.js (revision 972b65935d05780ec33a7337a4c28aab0d6fc9e7)
+++ b/src/services/signalingService.js (date 1771412086368)
@@ -26,7 +26,7 @@
* @param options
*/
async function pullSignalingMessages(token, options) {
- return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), options)
+ return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), { timeout: 1 })
}
|
Looping @danxuliu for a second opinion |
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
…t found
☑️ Resolves
Prevents the "Conversation not found" error page when a temporary network interruption (ECONNABORTED) occurs.
Previously, if a polling request was aborted (e.g., refreshing the page or unstable network), the user was kicked out of the conversation. This patch ignores ECONNABORTED errors just like we ignore isCancel.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Screenshot before

Screenshot after
No UI changes. The conversation loads normally instead of showing the "Conversation not found" error.
🚧 Tasks
🏁 Checklist