Skip to content

Fix(signaling): ignore ECONNABORTED errors to prevent conversation not found#17158

Merged
nickvergessen merged 3 commits intonextcloud:mainfrom
Paulcor35:fix-econnaborted-error
Mar 6, 2026
Merged

Fix(signaling): ignore ECONNABORTED errors to prevent conversation not found#17158
nickvergessen merged 3 commits intonextcloud:mainfrom
Paulcor35:fix-econnaborted-error

Conversation

@Paulcor35
Copy link

…t found

☑️ Resolves

Prevents the "Conversation not found" error page when a temporary network interruption (ECONNABORTED) occurs.

Previously, if a polling request was aborted (e.g., refreshing the page or unstable network), the user was kicked out of the conversation. This patch ignores ECONNABORTED errors just like we ignore isCancel.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Screenshot before
screen_problème

Screenshot after

No UI changes. The conversation loads normally instead of showing the "Conversation not found" error.

🚧 Tasks

  • Add ECONNABORTED to ignored errors in signaling.js

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

…t found

Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
@Antreesy Antreesy added bug feature: signaling 📶 Internal and external signaling backends feature: frontend 🖌️ "Web UI" client labels Feb 18, 2026
@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Feb 18, 2026
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise a good addition. Can reproduce locally with small patch (axios aborts request with this code when timeout, and in other cases) + Internal signaling

--- a/src/services/signalingService.js	(revision 972b65935d05780ec33a7337a4c28aab0d6fc9e7)
+++ b/src/services/signalingService.js	(date 1771412086368)
@@ -26,7 +26,7 @@
  * @param options
  */
 async function pullSignalingMessages(token, options) {
-	return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), options)
+	return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), { timeout: 1 })
 }
 

@Antreesy
Copy link
Contributor

Looping @danxuliu for a second opinion

CORNEN Paul added 2 commits February 18, 2026 12:05
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nickvergessen nickvergessen merged commit 79414ce into nextcloud:main Mar 6, 2026
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: frontend 🖌️ "Web UI" client feature: signaling 📶 Internal and external signaling backends feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants