Skip to content

πŸ”ƒ Permanent call rooms - βš™οΈ Backend#17169

Merged
nickvergessen merged 3 commits intomainfrom
feat/noid/conversation-presets-andy
Mar 5, 2026
Merged

πŸ”ƒ Permanent call rooms - βš™οΈ Backend#17169
nickvergessen merged 3 commits intomainfrom
feat/noid/conversation-presets-andy

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 18, 2026

β˜‘οΈ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@nickvergessen nickvergessen changed the base branch from main to feat/noid/conversation-presets February 18, 2026 14:08
@nickvergessen nickvergessen force-pushed the feat/noid/conversation-presets branch from e8a8123 to 2c81609 Compare February 19, 2026 07:55
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/conversation-presets-andy branch from 2ae0908 to 05d98f1 Compare February 19, 2026 09:35
@AndyScherzinger
Copy link
Member Author

Can't run the openAPI calls locally unfortunately

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/conversation-presets-andy branch 2 times, most recently from 6eb9324 to 52e2564 Compare February 19, 2026 12:45
Base automatically changed from feat/noid/conversation-presets to main February 19, 2026 13:03
@nickvergessen nickvergessen force-pushed the feat/noid/conversation-presets-andy branch from 52e2564 to afe870d Compare February 19, 2026 22:15
@miaulalala
Copy link
Contributor

    Given user "participant1" gets available presets with 200 (v1) # FeatureContext::userSeesTheFollowingPresets()
      | identifier   | name         | parameters                                                                                                                                               |
      | default      | default      | {"roomType":2,"readOnly":0,"listable":0,"messageExpiration":0,"lobbyState":0,"sipEnabled":0,"permissions":0,"recordingConsent":0,"mentionPermissions":0} |
      | forced       | forced       | []                                                                                                                                                       |
      | webinar      | Webinar      | {"lobbyState":1,"mentionPermissions":1,"permissions":389,"recordingConsent":1,"roomType":3}                                                              |
      | presentation | Presentation | {"mentionPermissions":1,"permissions":389,"recordingConsent":1}                                                                                          |
      | hallway      | Hallway      | {"listable":1,"messageExpiration":3600}                                                                                                                  |
      {"ocs":{"meta":{"status":"failure","statuscode":996,"message":"Internal Server Error\nCannot call abstract method OCA\\Talk\\RoomPresets\\APreset::getIdentifier() in file '\/home\/runner\/work\/spreed\/spreed\/apps\/spreed\/lib\/RoomPresets\/APreset.php' line 32"},"data":[]}}

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nickvergessen nickvergessen force-pushed the feat/noid/conversation-presets-andy branch 2 times, most recently from 9ac36c4 to 78a71c0 Compare March 4, 2026 15:59
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/noid/conversation-presets-andy branch from 78a71c0 to c522d1a Compare March 4, 2026 16:17
@nickvergessen nickvergessen removed their request for review March 4, 2026 16:24
@nickvergessen nickvergessen self-assigned this Mar 4, 2026
@nickvergessen
Copy link
Member

Since I did majority of the PR by now, could do review my part @miaulalala

@nickvergessen nickvergessen changed the title Feat/noid/conversation presets andy πŸ”ƒ Permanent call rooms - βš™οΈ Backend Mar 4, 2026
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks, but looks good


### Chat style
* `split` Split (default) - chat messages are split into two columns (with different sides per actor)
* `unified` Unified - chat messages are in a single column
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `unified` Unified - chat messages are in a single column
* `unified` Unified - chat messages are displayed in a single column

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow up to not run CI again with integration tests

?int $recordingConsent = null,
?int $mentionPermissions = null,
?string $description = null,
?int $attributes = null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

the plural sounds like it may be an array

Suggested change
?int $attributes = null,
?int $attributeBits = null,

@nickvergessen nickvergessen merged commit 2551c39 into main Mar 5, 2026
83 checks passed
@nickvergessen nickvergessen deleted the feat/noid/conversation-presets-andy branch March 5, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants