Skip to content

fix(ui): clarify duplicate session error message#17324

Merged
nickvergessen merged 1 commit intomainfrom
fix/app-name-7
Mar 9, 2026
Merged

fix(ui): clarify duplicate session error message#17324
nickvergessen merged 1 commit intomainfrom
fix/app-name-7

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Mar 9, 2026

☑️ Resolves

  • or device is not relevant for a long time
  • This is not about windows, but about web-browser tabs
  • Even tabs are now supported, so this is only a limitation for the user server version
  • Sessions is a technical term, not relevant for the end-user
  • Joined is also more technical (joined a session) that the user action (a user just opened a conversation)
  • Theming/branding neutral
  • Follow-up: add a button to close this tab and focus another one

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme
fix(ui): clarify duplicate session error message
5358f52 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 🏖️ Next Major (34) milestone Mar 9, 2026
@ShGKme ShGKme self-assigned this Mar 9, 2026
Antreesy
Antreesy approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@nickvergessen nickvergessen merged commit d80f4a2 into main Mar 9, 2026
55 checks passed
@nickvergessen nickvergessen deleted the fix/app-name-7 branch March 9, 2026 16:29
@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented Mar 12, 2026

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Mar 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Antreesy approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels

bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v24.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ShGKme @nickvergessen @Antreesy