fix(backgound): Move virtual background option from conversation to a…#17329
Merged
nickvergessen merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
…pp level Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
papercut
feature: settings ⚙️
Antreesy
reviewed
Mar 10, 2026
| 'videoInputDevicePreferred', // Not needed anymore | ||
|
|
||
| // Talk 33 | ||
| 'virtualBackgroundBlurStrength_', // Migration from conversation level to Talk level settings |
Contributor
There was a problem hiding this comment.
We're only using blurValue: VIRTUAL_BACKGROUND.BLUR_STRENGTH.DEFAULT across the codebase, maybe we simply drop virtualBackgroundBlurStrength (without underscore) completely and only rely on a constant?
Member
Author
There was a problem hiding this comment.
Can do that in a follow up, just in case backlash is bigger then assumed
Antreesy
approved these changes
Mar 11, 2026
DorraJaouad
approved these changes
Mar 11, 2026
Contributor
DorraJaouad
left a comment
DorraJaouad
left a comment
There was a problem hiding this comment.
@Antreesy btw older migrations are old enough IMO, we can clear them out soon?
Member
Author
I would keep them, in case a user updates over multiple versions. Doesn't really hurt |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pp level
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist