fix(ci): adjust run conditions for approve-merge steps#17443
Merged
nickvergessen merged 1 commit intomainfrom Mar 19, 2026
Merged
fix(ci): adjust run conditions for approve-merge steps#17443nickvergessen merged 1 commit intomainfrom
nickvergessen merged 1 commit intomainfrom
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
regression
github_actions
| - name: Auto merge | ||
| uses: alexwilson/enable-github-automerge-action@56e3117d1ae1540309dc8f7a9f2825bc3c5f06ff # v2.0.0 | ||
| if: github.event.pull_request.user.login == 'dependabot[bot]' | ||
| if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' && steps.auto_approve.conclusion == 'success' }} |
Member
There was a problem hiding this comment.
As long as there is no approval, it shouldn't matter?
Contributor
Author
There was a problem hiding this comment.
Feels consistent to me to have either 2 'yes' or 2 'no' for both steps
nickvergessen
approved these changes
Mar 19, 2026
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
env.ALLOW_MINORin if condition is a string, should be converted to boolean withfromJSON(env.ALLOW_MINOR)steps.auto_approve.conclusion == 'success'to execute or skipAI (if applicable)