Skip to content

fix: gracefully handle localStorage quota exceeding#17603

Merged
nickvergessen merged 1 commit intomainfrom
fix/17602/cache-conversations-to-BS
Apr 8, 2026
Merged

fix: gracefully handle localStorage quota exceeding#17603
nickvergessen merged 1 commit intomainfrom
fix/17602/cache-conversations-to-BS

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Apr 2, 2026

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

To test: add a loop to cacheConversations to bloat the size of stored characters

		for (let i = 0; i < 5; i++) {
			conversations.push(...conversations)
		}

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Broken UI image

🚧 Tasks

  • Follow-up: migrate to IndexedDB
    • Better chunking + caching on each change (now limited to deleting room + 30-sec update)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

- wrap dangerous function call with try-catch
- if it is an expected error, disable caching for conversations, no longer try to save in this session
- impact is minimal, should affect only users with 1000+ rooms, but other

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/17602/cache-conversations-to-BS branch from ad8d575 to 7a105b1 Compare April 2, 2026 15:29
@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Apr 2, 2026

/backport to stable33

@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Apr 2, 2026

/backport to stable32

@nickvergessen nickvergessen merged commit 562c0cf into main Apr 8, 2026
53 checks passed
@nickvergessen nickvergessen deleted the fix/17602/cache-conversations-to-BS branch April 8, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while fetching conversations: QuotaExceededError

2 participants