Skip to content

fix(bots): Hide event bots of disabled apps#17653

Merged
nickvergessen merged 1 commit intomainfrom
bugfix/17573/hide-app-bots-when-app-disabled
Apr 9, 2026
Merged

fix(bots): Hide event bots of disabled apps#17653
nickvergessen merged 1 commit intomainfrom
bugfix/17573/hide-app-bots-when-app-disabled

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen commented Apr 8, 2026 •
edited
Loading

☑️ Resolves

👣 Steps

  1. Enable call_summary_bot
  2. Disable call_summary_bot
  3. Go into a conversation as a moderator, open conversation settings and look at the available bots
    1. Disabled bots are not listed
    2. Enabled bots are listed as "Not available" with an error button
  4. Go into admin settings available bots
    1. Disabled bots are listed with "App disabled"
Before After
grafik grafik
grafik grafik
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 🏖️ Next Major (34) milestone Apr 8, 2026
@nickvergessen nickvergessen requested a review from miaulalala April 8, 2026 08:24
@nickvergessen nickvergessen self-assigned this Apr 8, 2026
@nickvergessen nickvergessen added bug feature: api 🛠️ OCS API for conversations, chats and participants feature: bots 🤖 /commands in chat messages labels Apr 8, 2026
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 8, 2026

/backport to stable33

@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 8, 2026

/backport to stable32

miaulalala
miaulalala requested changes Apr 8, 2026
View reviewed changes
Comment thread lib/Controller/BotController.php Outdated
@nickvergessen nickvergessen force-pushed the bugfix/17573/hide-app-bots-when-app-disabled branch 2 times, most recently from 02542a2 to e459123 Compare April 8, 2026 10:27
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 8, 2026 •
edited
Loading

build an array of already checked app Ids so you don't have to run the isEnabledForAnyone for apps that might already have been checked

App manager is doing that already.

I also changed the approach to still show them if they are enabled and to add error indicators for admins

@nickvergessen nickvergessen enabled auto-merge April 8, 2026 10:43
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 8, 2026

Of course the cheating app bot is breaking 🙈

@nickvergessen
fix(bots): Hide event bots of disabled apps
2a4e9c6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/17573/hide-app-bots-when-app-disabled branch from e459123 to 2a4e9c6 Compare April 9, 2026 10:33
nickvergessen
nickvergessen commented Apr 9, 2026
View reviewed changes
Comment thread lib/Command/Bot/Setup.php
return 1;
}

if (!$this->botService->isAppForBotEnabled($botServer)) {
Copy link
Copy Markdown
Member Author

@nickvergessen nickvergessen Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the ! here was missing, so its also tested :D

@nickvergessen nickvergessen merged commit 1342e1d into main Apr 9, 2026
78 checks passed
@nickvergessen nickvergessen deleted the bugfix/17573/hide-app-bots-when-app-disabled branch April 9, 2026 10:49
This was referenced Apr 9, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels

bug feature: api 🛠️ OCS API for conversations, chats and participants feature: bots 🤖 /commands in chat messages

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen @miaulalala