Skip to content

fix(translate): improve language detection in UI#17666

Merged
nickvergessen merged 4 commits intomainfrom
fix/17660/detect-language
Apr 10, 2026
Merged

fix(translate): improve language detection in UI#17666
nickvergessen merged 4 commits intomainfrom
fix/17660/detect-language

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Apr 9, 2026

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
initial open --
image image
picked languages --
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 3 commits April 9, 2026 10:46
@Antreesy
fix: migrate translationService to Typescript
6f5e4a0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: add 'Detect language' option in UI
338d2a8 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: defer detection of user language
84995d4 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Apr 9, 2026
@Antreesy Antreesy requested a review from DorraJaouad April 9, 2026 09:24
@Antreesy Antreesy self-assigned this Apr 9, 2026
nickvergessen
nickvergessen approved these changes Apr 10, 2026
View reviewed changes
Comment thread src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageTranslateDialog.vue Outdated
@Antreesy
fix: better handling of loading/disabled state
1132430 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/17660/detect-language branch from 0c0c1c0 to 1132430 Compare April 10, 2026 09:44
@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 10, 2026

/backport to stable33

@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 10, 2026

/backport to stable32

@nickvergessen nickvergessen merged commit 7fb9f2a into main Apr 10, 2026
53 checks passed
@nickvergessen nickvergessen deleted the fix/17660/detect-language branch April 10, 2026 09:50
This was referenced Apr 10, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

feat: add "Detect language" option to message translation source language dropdown

2 participants

@Antreesy @nickvergessen