Skip to content

fix: fix loading shares in folder when share is moved#17769

Merged
nickvergessen merged 1 commit intomainfrom
shares-in-folder-renamed
Apr 21, 2026
Merged

fix: fix loading shares in folder when share is moved#17769
nickvergessen merged 1 commit intomainfrom
shares-in-folder-renamed

Conversation

@icewind1991
Copy link
Copy Markdown
Member

Trying to construct the target of the parent share doesn't work if the share is moved, but also isn't necessary if we already match the path of the moved share.

Server master doesn't currently trigger the bug in the integration tests because cache gc is triggering a full fs setup (nextcloud/server#52000)

Signed-off-by: Robin Appelman <robin@icewind.nl>
@nickvergessen nickvergessen added bug feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: upload & shares & voice πŸ“€πŸŽ™οΈ Sharing files into a chat and audio recordings labels Apr 20, 2026
@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 21, 2026

The integration test makes sense.

It fails on master server with commented out GC in base.php and passes with this PR in the same case

    When user "participant3" gets the DAV properties for "/Talk/test"                   # SharingContext::userGetsTheDavPropertiesFor()
    Then the list of returned files for "participant3" is                               # SharingContext::theListOfReturnedFilesForIs()
      | /Talk/test/            |
      | /Talk/test/renamed.txt |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       Array (
           0 => '/remote.php/dav/files/partici.../test/'
      -    1 => '/remote.php/dav/files/partici...ed.txt'
       )

@nickvergessen
Copy link
Copy Markdown
Member

/backport to stable33

@nickvergessen nickvergessen merged commit 1c25e0d into main Apr 21, 2026
79 checks passed
@nickvergessen nickvergessen deleted the shares-in-folder-renamed branch April 21, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: upload & shares & voice πŸ“€πŸŽ™οΈ Sharing files into a chat and audio recordings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants