Skip to content

fix(call): hide remaining call-related UI when calls are disabled#17788

Merged
Antreesy merged 5 commits intonextcloud:mainfrom
notoriousisk:hide-call-features
Apr 24, 2026
Merged

fix(call): hide remaining call-related UI when calls are disabled#17788
Antreesy merged 5 commits intonextcloud:mainfrom
notoriousisk:hide-call-features

Conversation

@notoriousisk
Copy link
Copy Markdown
Contributor

Hello! This is my first contribution to this repository. Looking forward to your feedback

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Dashboard actions and upcoming meetings

🏚️ Before 🏡 After
Dashboard before Dashboard after

App settings: devices / appearance

🏚️ Before 🏡 After
App settings before App settings after

Keyboard shortcuts

🏚️ Before 🏡 After
Keyboard shortcuts before Keyboard shortcuts after

Participant permissions

🏚️ Before 🏡 After
Participant permissions before Participant permissions after

Conversation notification settings

🏚️ Before 🏡 After
Conversation notifications before Conversation notifications after

🚧 Tasks

  • Hide remaining call-related dashboard actions when calls are disabled
  • Hide dashboard join buttons for upcoming meetings when calls are disabled
  • Hide call-only app settings sections and shortcuts when calls are disabled
  • Hide conversation call-related settings and SIP-related sidebar actions when calls are disabled
  • Disable call-related permission controls when calls are disabled while keeping non-call permissions editable

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

nickvergessen
nickvergessen previously approved these changes Apr 24, 2026
Signed-off-by: Iskander Ishkineev <notoriousisk@gmail.com>
Signed-off-by: Iskander Ishkineev <notoriousisk@gmail.com>
Signed-off-by: Iskander Ishkineev <notoriousisk@gmail.com>
Signed-off-by: Iskander Ishkineev <notoriousisk@gmail.com>
@notoriousisk
Copy link
Copy Markdown
Contributor Author

Force-pushed to fix DCO: rewrote the 4 commits so author/signoff match correctly. No code changes.

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work done! Left some comments on the changes:

Comment thread src/components/PermissionsEditor/PermissionsEditor.vue Outdated
Comment thread src/components/RightSidebar/Participants/ParticipantsTab.vue Outdated
Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
Comment thread src/components/ConversationSettings/NotificationsSettings.vue
Comment thread src/components/ConversationSettings/ConversationSettingsDialog.vue Outdated
Comment thread src/components/ConversationSettings/ConversationSettingsDialog.vue Outdated
Comment thread src/components/ConversationSettings/ConversationSettingsDialog.vue Outdated
Comment thread src/components/ConversationSettings/ConversationPermissionsSettings.vue Outdated
Comment thread src/components/PermissionsEditor/PermissionsEditor.vue
@Antreesy Antreesy dismissed nickvergessen’s stale review April 24, 2026 11:19

to prevent merge before comments addressed

Signed-off-by: Iskander Ishkineev <notoriousisk@gmail.com>
@notoriousisk
Copy link
Copy Markdown
Contributor Author

Thanks for the review
Addressed the review comments and pushed the requested changes.
I applied the suggested simplifications, added the missing call-notification check in the sidebar, and updated the permissions settings hints so they only change when calls are disabled.
@Antreesy could you take another look?

@notoriousisk notoriousisk requested a review from Antreesy April 24, 2026 14:38
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice now, tested.
Thanks for the great contribution! 🎉

@Antreesy Antreesy merged commit 6211d9b into nextcloud:main Apr 24, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Hide call-related settings and dashboard buttons when calls are disabled (Follow-up to #17215)

3 participants