fix: respect participant permissions for hardware access#17976
Merged
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Contributor
Author
|
/backport to stable33 |
Member
|
I think we did this so granting permissions afterwards does not lead to a disconnect which then prompts the device picker with permissions request during the call, but up front already 🙈 But I think that is a "edge case" from our company call setup |
Contributor
Author
There is still a device picker working in background and before call, so general media-permission fo browser should be granted by then. During the call, it's more about holding the device (for no reasons, if there are no permissions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
useDeviceshas 2-3 subscribers during the call:subscribersCount, where we only respect existing of subscribers, but not what they requesting.AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist