Skip to content

fix: respect participant permissions for hardware access#17976

Merged
Antreesy merged 1 commit into
mainfrom
fix/noid/cam-access
May 13, 2026
Merged

fix: respect participant permissions for hardware access#17976
Antreesy merged 1 commit into
mainfrom
fix/noid/cam-access

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix 'hardware cam light on in call with no camera permissions'
    • useDevices has 2-3 subscribers during the call:
      • audio control button
      • video control button
      • device preview dialog
  • If user has no permissions to enable mic / camera during the call (e.g. in webinar), then MediaDeviceManager should not try to get media devices for audio / video
  • refactor previous logic with subscribersCount, where we only respect existing of subscribers, but not what they requesting.
    • internal logic for composable, no reactivity needed
  • in theory - should not block using devices by other apps at the same time

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Light on Light off

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🏖️ Next Beta (34) milestone May 12, 2026
@Antreesy Antreesy requested review from DorraJaouad and ShGKme May 12, 2026 15:54
@Antreesy Antreesy self-assigned this May 12, 2026
@Antreesy Antreesy added feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels May 12, 2026
@Antreesy
Copy link
Copy Markdown
Contributor Author

/backport to stable33

Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Tested ✅

@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented May 13, 2026

I think we did this so granting permissions afterwards does not lead to a disconnect which then prompts the device picker with permissions request during the call, but up front already 🙈

But I think that is a "edge case" from our company call setup

@Antreesy
Copy link
Copy Markdown
Contributor Author

I think we did this so granting permissions afterwards does not lead to a disconnect which then prompts the device picker with permissions request during the call

There is still a device picker working in background and before call, so general media-permission fo browser should be granted by then. During the call, it's more about holding the device (for no reasons, if there are no permissions).
From the tests, it was resolved correctly, keeping the mic/camera off

@Antreesy Antreesy merged commit 5cdea8a into main May 13, 2026
53 checks passed
@Antreesy Antreesy deleted the fix/noid/cam-access branch May 13, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants