fix(signaling): allow SIP bridge to access getSettings without a user session#18115
Merged
Conversation
miaulalala
added
bug
regression
feature: api 🛠️
Contributor
Author
|
/backport to stable34 |
fancycode
approved these changes
May 27, 2026
Member
fancycode
left a comment
fancycode
left a comment
There was a problem hiding this comment.
Thanks! Was about to work on the same change :-)
Tested and works as expected, didn't check the code though.
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
… session The security fix in #17576 tightened unauthenticated access to getSettings(), breaking SIP bridge connections. The SIP bridge is a headless service with no userId that authenticates via HMAC headers (talk-sipbridge-random / talk-sipbridge-checksum), which getSettings() was never taught to recognise. Mirror the existing recording-backend detection block: validate the SIP bridge headers when present, return 401 + brute-force throttle on failure, and allow the no-token neutral-point path when the request is authenticated. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/noid/sip-bridge-token-check
branch
from
9ac3329 to
c082659
Compare
This was referenced May 27, 2026
Open
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18106
userId) that authenticates via HMAC headers (talk-sipbridge-random/talk-sipbridge-checksum), whichgetSettings()was never taught to recognise$room = null) for authenticated SIP bridge requestsTest plan
tests/php/Controller/SignalingControllerTest.phpinside the Docker container to confirm all new tests passGET /api/v3/signaling/settingsreturns 200 with valid headers and 401 with invalid ones🤖 AI-Assisted-By: claude-sonnet-4-6