[stable33] fix: Allow accessing some admin endpoints to admins that can not use Talk#18126
Merged
Conversation
Since Talk 21 the connection check for the signaling server in Talk administration settings fetches the signaling settings, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Talk administration settings fetches the list of all bots, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot
Bot
added
bug
regression
feature: settings ⚙️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #18107