Skip to content

fix(virtual-bg): stop effect when not in use#18205

Open
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/disabled-bg-blur
Open

fix(virtual-bg): stop effect when not in use#18205
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/disabled-bg-blur

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Jun 3, 2026

β˜‘οΈ Resolves

  • in VideoStreamBackgroundEffect, stopEffect() is not properly called on disabling video stream, which leads to:
    • TimerWorker still running
    • _renderMask still called
    • mask still calculated on the black frame (taking 50% of time/resources compared to enabled video)
  • During call:
    • _stopEffect() on a node processor stopping bg effect regardless of input stream state
  • While checking devices:
    • effect lives as long as dialog is opened (no parallel inference during call)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

Running the same pattern:

  1. Camera off, blur off
  2. Camera on, blur off
  3. Camera on, blur on
  4. Camera off, blur on (fix)
🏚️ Before 🏑 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the β›… Next Major (35) milestone Jun 3, 2026
@Antreesy Antreesy requested review from DorraJaouad and danxuliu June 3, 2026 09:33
@Antreesy Antreesy self-assigned this Jun 3, 2026
@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Jun 3, 2026

/backport to stable34

@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Jun 3, 2026

/backport to stable33

@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Jun 3, 2026

/backport to stable32

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/disabled-bg-blur branch from 9e9433e to 8d23b71 Compare June 3, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant