fix(sharing): Allow sharing with read-write again

[nickvergessen]

☑️ Resolves

• Fix #…

Tested with:

diff --git a/src/services/filesSharingServices.ts b/src/services/filesSharingServices.ts
index 756644149a..d6fc9866c3 100644
--- a/src/services/filesSharingServices.ts
+++ b/src/services/filesSharingServices.ts
@@ -77,7 +77,7 @@ async function createNewFile({ filePath, templatePath, templateType }: createFil
  *         and a rename simulation for the requested file names.
  */
 async function probeAttachmentFolder({ token, fileNames }: { token: string } & ProbeAttachmentFolderParams): ProbeAttachmentFolderResponse {
-       return axios.post(generateOcsUrl('apps/spreed/api/v1/chat/{token}/attachment/folder', { token }), { fileNames })
+       return axios.post(generateOcsUrl('apps/spreed/api/v1/chat/{token}/attachment/folder', { token }), { fileNames, allowUpdate: true })
 }
 
 /**
@@ -106,6 +106,7 @@ async function postAttachment({ token, filePath, fileName, referenceId, talkMeta
                fileName,
                referenceId,
                talkMetaData,
+               allowUpdate: true,
        })
 }
 

🛠️ API Checklist

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[Antreesy]

Tested

[nickvergessen]

Run integration:                          tests/integration/features/sharing-1/conversation-folder.feature#L214                                                                                                  When user "participant3" probes  attachment folder for room "one-to-one room" with files  "rep<o>rt.txt,nul.txt,rep:o:rt.txt" with 200 (v1)  Type error: Too few arguments to function  SharingContext::sendingToTalkAttachmentFolderProbe(), 2 passed in  /home/runner/actions-runner/_work/spreed/spreed/apps/spreed/tests/integration/features/bootstrap/SharingContext.php  on line 139 and exactly 3 expected  (Behat\Testwork\Call\Exception\FatalThrowableError)
Run integration:                          tests/integration/features/sharing-1/conversation-folder.feature#L204                                                                                                  When user "participant1" probes  attachment folder for room "group room" with files "photo.jpg" with 200  (v1)  Type error: Too few arguments to function  SharingContext::sendingToTalkAttachmentFolderProbe(), 2 passed in  /home/runner/actions-runner/_work/spreed/spreed/apps/spreed/tests/integration/features/bootstrap/SharingContext.php  on line 139 and exactly 3 expected  (Behat\Testwork\Call\Exception\FatalThrowableError)
Run integration:                          tests/integration/features/sharing-1/conversation-folder.feature#L191                                                                                                  When user "participant1" probes  attachment folder for room "group room" with files "photo.jpg,  notes.txt" with 200 (v1)  Type error: Too few arguments to function  SharingContext::sendingToTalkAttachmentFolderProbe(), 2 passed in  /home/runner/actions-runner/_work/spreed/spreed/apps/spreed/tests/integration/features/bootstrap/SharingContext.php  on line 139 and exactly 3 expected  (Behat\Testwork\Call\Exception\FatalThrowableError)
Run integration:                          tests/integration/features/sharing-1/conversation-folder.feature#L172                                                                                                  When user "participant1" posts temp file  "unique.txt" with name "unique.txt" from conversation folder of room  "group room" with name "Group room" with 200 (v1)  Type error: Too few arguments to function  SharingContext::ensureDraftFolderViaProbe(), 2 passed in  /home/runner/actions-runner/_work/spreed/spreed/apps/spreed/tests/integration/features/bootstrap/SharingContext.php  on line 124 and exactly 3 expected  (Behat\Testwork\Call\Exception\FatalThrowableError)
Run integration:                          tests/integration/features/sharing-1/conversation-folder.feature#L163                                                                                                  When user "participant1" posts temp file  "temp-upload.txt" with name "test.txt" from conversation folder of room  "group room" with name "Group room" with 200 (v1)  Type error: Too few arguments to function  SharingContext::ensureDraftFolderViaProbe(), 2 passed in  /home/runner/actions-runner/_work/spreed/spreed/apps/spreed/tests/integration/features/bootstrap/SharingContext.php  on line 124 and exactly 3 expected  (Behat\Testwork\Call\Exception\FatalThrowableError)

Old tests need adjustments

[nickvergessen]

/backport to stable34

[backportbot]

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/18485/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ea847752 20944dd7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/18485/stable34

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/18485/stable34."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.