Remove undefined property or method usage #7119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from dd8d415 Signed-off-by: Joas Schilling <coding@schilljs.com>
| :main-text="getMainText(item)" | ||
| :sub-text="getSubText(item)" | ||
| :item="item" | ||
| v-on="handlers"> |
Member
There was a problem hiding this comment.
was it maybe meant to be v-on="$listeners"?
Member
Author
There was a problem hiding this comment.
No, I copied the content from:
https://github.com/nextcloud/nextcloud-vue-dashboard/blob/de7e24fdbb0f53cdbe0affddfd219bbd335399a2/src/DashboardWidget.vue#L46
And while adjusting forgot to remove it. We have no handlers in talk
marcoambrosini
approved these changes
Apr 8, 2022
marcoambrosini
deleted the
bugfix/6868/remove-undefined-property-or-method-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from dd8d415
Fix #6868