Skip to content

fix/2555: share delete and public link access#2556

Merged
samin-z merged 3 commits intomainfrom
fix/2555-share-delete
Apr 30, 2026
Merged

fix/2555: share delete and public link access#2556
samin-z merged 3 commits intomainfrom
fix/2555-share-delete

Conversation

@samin-z
Copy link
Copy Markdown
Contributor

@samin-z samin-z commented Apr 30, 2026

apply share delete and public link access respecting to limitations

@samin-z samin-z requested review from blizzz and enjeck as code owners April 30, 2026 10:35
@samin-z samin-z requested a review from benjaminfrueh April 30, 2026 10:35
@benjaminfrueh
Copy link
Copy Markdown
Contributor

benjaminfrueh commented Apr 30, 2026

@samin-z as we just discussed, this could maybe be simplified.
The public controller should not use the user session as it should not require a user and only use the token (and optionally a password) to authenticate.

I think the easiest way would be to get the sender user from the share and simply validate this user with sharingDisabledForUser() - I didn't test that though.

The files app does the public link checks checks in https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareController.php#L263
Maybe it makes sense for tables to also check if the share sender user is disabled, and also deny access then, like the files_app already does.

@samin-z samin-z force-pushed the fix/2555-share-delete branch from 90f1cdc to 83d6af3 Compare April 30, 2026 17:05
samin-z added 2 commits April 30, 2026 19:46
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z samin-z force-pushed the fix/2555-share-delete branch from 3093d31 to b3541a8 Compare April 30, 2026 17:52
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z samin-z force-pushed the fix/2555-share-delete branch from b3541a8 to b8a1e64 Compare April 30, 2026 18:01
@samin-z samin-z merged commit 1fa1aac into main Apr 30, 2026
67 of 69 checks passed
@samin-z samin-z deleted the fix/2555-share-delete branch April 30, 2026 19:26
@samin-z
Copy link
Copy Markdown
Contributor Author

samin-z commented Apr 30, 2026

/backport! to stable1.0

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Apr 30, 2026
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 30, 2026

The backport to stable1.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable1.0
git pull origin stable1.0

# Create the new backport branch
git checkout -b backport/2556/stable1.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9424787 da998666 b8a1e64d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2556/stable1.0

Error: Failed to check for changes with origin/stable1.0: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@samin-z
Copy link
Copy Markdown
Contributor Author

samin-z commented Apr 30, 2026

/backport! to stable0.9

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 30, 2026

The backport to stable0.9 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable0.9
git pull origin stable0.9

# Create the new backport branch
git checkout -b backport/2556/stable0.9

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9424787 da998666 b8a1e64d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2556/stable0.9

Error: Failed to check for changes with origin/stable0.9: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-request Pending backport by the backport-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants