fix/2555: share delete and public link access#2556
Conversation
|
@samin-z as we just discussed, this could maybe be simplified. I think the easiest way would be to get the sender user from the share and simply validate this user with The files app does the public link checks checks in https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareController.php#L263 |
90f1cdc to
83d6af3
Compare
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
3093d31 to
b3541a8
Compare
b3541a8 to
b8a1e64
Compare
|
/backport! to stable1.0 |
|
The backport to # Switch to the target branch and update it
git checkout stable1.0
git pull origin stable1.0
# Create the new backport branch
git checkout -b backport/2556/stable1.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9424787 da998666 b8a1e64d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2556/stable1.0Error: Failed to check for changes with origin/stable1.0: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport! to stable0.9 |
|
The backport to # Switch to the target branch and update it
git checkout stable0.9
git pull origin stable0.9
# Create the new backport branch
git checkout -b backport/2556/stable0.9
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9424787 da998666 b8a1e64d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2556/stable0.9Error: Failed to check for changes with origin/stable0.9: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
apply share delete and public link access respecting to limitations