Skip to content

Fixing race condition in Message Input Fragment #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahibi merged 2 commits into from
Dec 16, 2025
Merged

Fixing race condition in Message Input Fragment #5608

mahibi merged 2 commits into from
Dec 16, 2025

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Dec 2, 2025 •
edited
Loading

🚧 TODO

  • spreed capabilities guaranteed not null
  • Fix message drafts not saving on orientation changes

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Dec 2, 2025
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Dec 2, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi December 4, 2025 14:54
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2025
@rapterjet2004 @mahibi
refactoring init logic to ensure spreed capabilities is not null
d226a08 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 @mahibi
linter
3cf5d4e 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi force-pushed the issue-5603-fix-race-condition branch from e54738c to 3cf5d4e Compare December 16, 2025 10:18
@mahibi mahibi enabled auto-merge December 16, 2025 10:18
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5608.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi mahibi disabled auto-merge December 16, 2025 12:54
@mahibi mahibi merged commit e611d31 into master Dec 16, 2025
16 of 17 checks passed
@mahibi mahibi deleted the issue-5603-fix-race-condition branch December 16, 2025 12:54
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Dec 18, 2025
@rapterjet2004 rapterjet2004 mentioned this pull request Dec 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

22.1.0

Development

Successfully merging this pull request may close these issues.

crashes related to MessageInputFragment initialzation

4 participants

@rapterjet2004 @mahibi @AndyScherzinger