Skip to content

Move avatar outside of searchbar #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Dec 29, 2025
Merged

Move avatar outside of searchbar #5673

AndyScherzinger merged 1 commit into from
Dec 29, 2025
+110 −99

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Dec 29, 2025 •
edited
Loading

Harmonize searchbar, compare to nextcloud/notes-android#2940 (or any Google app)

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger
style(searchbar): Move avatar outside of searchbar
49d1326 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Dec 29, 2025
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Dec 29, 2025
@AndyScherzinger AndyScherzinger changed the title style(searchbar): Move avatar outside of searchbar Move avatar outside of searchbar Dec 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Codacy

Lint

TypemasterPR
Warnings9997
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5673.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 633c6a0 into master Dec 29, 2025
18 of 20 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/searchBarRevamp branch December 29, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger @sowjanyakch