Skip to content

fix links#6193

Merged
mahibi merged 7 commits into
masterfrom
bugfix/QuotedLinks
May 28, 2026
Merged

fix links#6193
mahibi merged 7 commits into
masterfrom
bugfix/QuotedLinks

Conversation

@sowjanyakch
Copy link
Copy Markdown
Contributor

@sowjanyakch sowjanyakch commented May 13, 2026 •
edited
Loading

  • Disable underlining of links, email addresses, and phone numbers in quoted messages.

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft May 13, 2026 17:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25814812016/artifacts/6977010448
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@sowjanyakch sowjanyakch force-pushed the bugfix/QuotedLinks branch from df8e7f0 to 05e60d8 Compare May 19, 2026 08:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26086724966/artifacts/7079129572
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@sowjanyakch sowjanyakch force-pushed the bugfix/QuotedLinks branch from 6def2cf to fe12986 Compare May 19, 2026 14:09
@sowjanyakch sowjanyakch marked this pull request as ready for review May 19, 2026 14:13
@sowjanyakch sowjanyakch self-assigned this May 19, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label May 19, 2026
@sowjanyakch sowjanyakch force-pushed the bugfix/QuotedLinks branch from fe12986 to 61980f0 Compare May 20, 2026 14:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26167898091/artifacts/7114591357
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@sowjanyakch @mahibi
fix links
95eaaf7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
fix quoted links - don't underline
7b72f3d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
make entire quoted text clickable
fd27a64 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
fix detekt
a2b106e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
fix valid links - only links with protocol are clickable
49cc9d7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi mahibi force-pushed the bugfix/QuotedLinks branch from 61980f0 to 49cc9d7 Compare May 26, 2026 17:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26465047037/artifacts/7222090102
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

mahibi added 2 commits May 27, 2026 11:25
@mahibi
fix linkify order so URLs, phone numbers and emails all become links
2d3cbf9 
  Linkify.addLinks with a bitmask can clear existing URLSpans before
  adding its own. Running the URL regex after the phone/email pass
  caused the URL span to be wiped. Phone/email now runs first so the
  URL regex span is never overwritten.

AI-assistant: 1.9.1-251 (GPT-5.2-Codex)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
add enableLinks flag
ad59bde 
The enableLinks flag flows correctly through the call chain. Regular messages (via EnrichedText) keep the default enableLinks = true so URLs and markdown links are clickable; quoted messages pass enableLinks = false so neither render as tappable links — tapping anywhere on the quote navigates to the original message instead.

AI-assistant: 1.9.1-251 (GPT-5.2-Codex)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented May 27, 2026 •
edited
Loading

If a message contained multiple links/mails/phonenumbers some links were broken.
MentionEnrichedText is used elsewhere so it needs a flag to show links or not.

Fixed with the last 2 commits

@mahibi mahibi merged commit af697ca into master May 28, 2026
14 of 21 checks passed
@mahibi mahibi deleted the bugfix/QuotedLinks branch May 28, 2026 09:06
@AndyScherzinger
Copy link
Copy Markdown
Member

AndyScherzinger commented May 28, 2026

/backport to stable-24.0

@AndyScherzinger AndyScherzinger added this to the 24.1.0 milestone May 28, 2026
@backportbot backportbot Bot mentioned this pull request May 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

24.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sowjanyakch @mahibi @AndyScherzinger