Skip to content

Added dialog before entering a voice room + additional string#6209

Merged
mahibi merged 1 commit into
masterfrom
issue-6191-audio-only-voice-room
May 28, 2026
Merged

Added dialog before entering a voice room + additional string#6209
mahibi merged 1 commit into
masterfrom
issue-6191-audio-only-voice-room

Conversation

@rapterjet2004
Copy link
Copy Markdown
Contributor

@rapterjet2004 rapterjet2004 commented May 15, 2026 •
edited
Loading

🖼️ Screenshots

Screen_recording_20260518_101405.webm

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this May 15, 2026
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25934309823/artifacts/7023902248
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 requested a review from mahibi May 18, 2026 15:14
@rapterjet2004 @mahibi
Added dialog before entering a voice room + additional string
573c58d 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi force-pushed the issue-6191-audio-only-voice-room branch from d5e6034 to 573c58d Compare May 28, 2026 12:01
mahibi
mahibi approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will merge this PR
However during testing permanent call rooms now i saw that there are bugs with multiple app instances being opened. I will fix this in another PR

@mahibi mahibi merged commit 9be68d5 into master May 28, 2026
11 of 17 checks passed
@mahibi mahibi deleted the issue-6191-audio-only-voice-room branch May 28, 2026 12:04
@AndyScherzinger AndyScherzinger added this to the 24.1.0 milestone May 28, 2026
@AndyScherzinger
Copy link
Copy Markdown
Member

AndyScherzinger commented May 28, 2026

/backport to stable-24.0

@backportbot backportbot Bot mentioned this pull request May 28, 2026
Merged
@nextcloud nextcloud deleted a comment from backportbot Bot May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/26573416409/artifacts/7265964385
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

24.1.0

Development

Successfully merging this pull request may close these issues.

Allow audio only voice rooms

3 participants

@rapterjet2004 @AndyScherzinger @mahibi