Improve mark as read logic#6213
Merged
Merged
Conversation
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/25992339992/artifacts/7042914076 |
Resolves: #6059 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
d6349e3 to
f789bc1
Compare
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/26211543633/artifacts/7129764853 |
Member
Author
|
Merging in alignment, to have it tested, works well for me, maybe a bit to well in marking as read without having scrolled to the bottom completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #6059
According to our friend Claude:
The mark-as-read effect had two independent bugs:
The fix makes the effect re-evaluate whenever the message list changes, and replaces the index-based item lookup with a search that skips non-message entries and reliably resolves the newest actual message.
🚧 TODO
🏁 Checklist
/backport to stable-xx.x