Issue 6170 further improve search results order#6256
Merged
Conversation
5 tasks
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Replace the custom processOrderAndAdd helper and its pattern-based predicates with plain forEach iteration, letting the server-returned order stand. The previous implementation had variable shadowing, an inconsistent regex for contacts (\s* instead of \b), and duplicated the word-boundary pattern three times. AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
issue-6170-furtherImproveSearchResultsOrder
branch
from
d146880 to
4a9e7e7
Compare
Introduce sortedByMatchQuality to rank results within each section: exact title match first, then prefix (starts-with), then whole-word (\b), then substring — with 1-on-1 conversations ranked above groups within each tier and match position as a final tiebreaker. AI-assistant: Claude Code v2.1.142 (Claude Sonnet 4.6) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
issue-6170-furtherImproveSearchResultsOrder
branch
from
4a9e7e7 to
83e7c86
Compare
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/26638185462/artifacts/7291180096 |
Collaborator
Author
|
/backport to stable-24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative approach to #6192 to resolve #6170
This is not 100% the server behavior, but i claim it's a bit better looking at the results.
🏁 Checklist
/backport to stable-xx.x