-
Notifications
You must be signed in to change notification settings - Fork 64
fix(help): redesign #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(help): redesign #1607
Conversation
nimishavijay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks better :)
Would it be possible to remove the Cancel button in Windows and Linux?
I think there doesn't need to be 100% visual parity between different OSes, and more important is how native it feels and how good it looks in each OS. Unless it's not possible technically we don't have to do it the exact same way for all :)
I am also seeing a lot of "Done" buttons in macos screenshots so I am wondering if we should use that instead of "Cancel", what do you think?
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise also good
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
5068217 to
3698b65
Compare


☑️ Resolves
---from the title column)🖼️ Screenshots