Skip to content

feat: Validate password policy#2383

Merged
SystemKeeper merged 3 commits intomainfrom
feat/noid/validate-password-policy
Feb 6, 2026
Merged

feat: Validate password policy#2383
SystemKeeper merged 3 commits intomainfrom
feat/noid/validate-password-policy

Conversation

@Ivansss
Copy link
Copy Markdown
Member

@Ivansss Ivansss commented Feb 4, 2026

IMG_E0319 IMG_E0320 IMG_E0324

@Ivansss Ivansss requested a review from SystemKeeper February 4, 2026 17:11
Comment thread NextcloudTalk/Settings/NCSettingsController.m Outdated
@SystemKeeper
Copy link
Copy Markdown
Collaborator

This feels kind of weird at some points, e.g. when a password is set, you cannot change it:
Bildschirmfoto 2026-02-05 um 20 59 47

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-02-05.at.21.06.50.mov

Password is reset:

  • Write something
  • Show the password
  • Hide the password
  • Write again
  • -> Password remove

(No objection from my side, more a corner case I guess)

Subtitle update
The subline should be updated when the input changed, it feels a bit weird seeing this:

image

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss force-pushed the feat/noid/validate-password-policy branch from 6aed356 to ab496d6 Compare February 6, 2026 15:16
@SystemKeeper SystemKeeper merged commit 636d302 into main Feb 6, 2026
15 of 17 checks passed
@SystemKeeper SystemKeeper deleted the feat/noid/validate-password-policy branch February 6, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants