feat(signature): allow to provide custom signature#745
Merged
Conversation
Altahrim
force-pushed
the
feat/self-provided-signature
branch
3 times, most recently
from
61629a3 to
bd0a2bb
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/self-provided-signature
branch
from
bd0a2bb to
f414c80
Compare
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
susnux
approved these changes
Apr 21, 2026
| if ($signature === '') { | ||
| if ($urlOverride !== '') { | ||
| throw new \Exception( | ||
| 'Custom download url provided. You need to provide a signature with --signature or skip integrity check with --no-verify.' |
Contributor
There was a problem hiding this comment.
quality of life idea here would be to try DOWNLOADURL.asc in case you just have a custom proxy server but files are the same (or manually specify a download versions).
Collaborator
Author
There was a problem hiding this comment.
Agree!
Actually I tried to do it but .asc is a GPG signature and we need gnupg module or an external command to verify signature.
Unless I am missing something else?
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.