fix: Fix explode calls for path parsing#760
Merged
Merged
Conversation
Always pass a limit of 2 when using explode in this way avoids bugs when the path contains several times the delimiter by chance. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-backup-when-nextcloud-app
branch
from
4801e2a to
bdd92c2
Compare
…sion Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-backup-when-nextcloud-app
branch
from
bdd92c2 to
7f35d6f
Compare
skjnldsv
approved these changes
May 28, 2026
Collaborator
Author
|
The failing test is unrelated I believe. I had this failure locally as well recently, but I believe it needs to be fixed in the app. |
Collaborator
|
I can confirm issue is unrelated. |
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always pass a limit of 2 when using explode in this way avoids bugs when
the path contains several times the delimiter by chance.