added logging of errors for imap login#102
Merged
violoncelloCH merged 2 commits intonextcloud:masterfrom Sep 1, 2019
Merged
Conversation
Signed-off-by: Mischa Siekmann <github@gnumpi.com>
Member
violoncelloCH
left a comment
violoncelloCH
left a comment
There was a problem hiding this comment.
thanks for your contribution!
apart from the mentioned code styling, this looks good and makes sense!
will test this as soon as I'll find some time for it :)
violoncelloCH
changed the title
Signed-off-by: Mischa Siekmann <github@gnumpi.com>
This was referenced Aug 31, 2019
violoncelloCH
approved these changes
Sep 1, 2019
Member
violoncelloCH
left a comment
violoncelloCH
left a comment
There was a problem hiding this comment.
gave this a quick test run and it works really nice!
thank you very much @gnumpi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
In the case of IMAP authentication, passing errors of the roundcube based module to the OC error logger.