Setting authorization header globally in basicauth.php is dangerous (fix for #141)#142
Merged
nerdmaennchen merged 1 commit intonextcloud:masterfrom Apr 23, 2020
Merged
Conversation
* Authorization header for OC_User_BasicAuth is now set with locally stream context instead globally with stream_context_set_default function. * HTTP Redirects in OC_User_BasicAuth are disabled now, so authorization header can not be forwared to foreign servers. Closes nextcloud#141 Signed-off-by: Björn Voigt <bjoernv@arcor.de>
bjoernv
changed the title
nerdmaennchen
approved these changes
Apr 23, 2020
Member
|
Hey there. Thank you so much for bringing this up! Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
Changes proposed in this pull request: