Add NC31/32 compatibility and rewrite test suite#283
Merged
miaulalala merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
miaulalala
force-pushed
the
nc31-compatibility
branch
4 times, most recently
from
a520c6b to
21544a9
Compare
- Bump version to 3.6.0, set NC compatibility to min=31 max=32 - Replace deprecated OC::$server service locators with constructor-injected IDBConnection, IUserManager, IGroupManager (optional params for BC) - Replace $query->execute() with executeQuery()/executeStatement() and fetchColumn() with fetchOne() (NC32 DB API changes) - Add resolveUid() to Base: maps email login names back to stored uids for NC32 email-to-uid resolution; call it in all checkPassword() impls - Remove dead old tests (wrong class names, removed NC APIs, never ran) - Add PHPUnit 11 test infrastructure via vendor-bin pattern - Add 19 unit tests for Base with mocks (tests/unit/BaseTest.php) - Add 14 integration tests against live NC DB (tests/integration/) - Align bootstrap, phpunit.xml and composer scripts with NC app conventions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Each workflow uses the nextcloud-version-matrix action to test against all supported NC/PHP version combinations, runs both unit and integration test suites via composer scripts, and includes a path-filter to skip unchanged code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
nc31-compatibility
branch
from
21544a9 to
7345cda
Compare
This was referenced Mar 20, 2026
Closed
AndyScherzinger
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.