Skip to content

Cast key to string when retrieving value type#1064

Merged
come-nc merged 1 commit intonextcloud:mainfrom
yukogan-gh:patch-1
Mar 31, 2026
Merged

Cast key to string when retrieving value type#1064
come-nc merged 1 commit intonextcloud:mainfrom
yukogan-gh:patch-1

Conversation

@yukogan-gh
Copy link
Copy Markdown
Contributor

This to prevent a typeerror.

"Argument #3 ($key) must be of type string, int given."

Signed-off-by: Yuri Van Hamme yuko@gmx.li

This to prevent a typeerror.

"Argument nextcloud#3 ($key) must be of type string, int given."

Signed-off-by: Yukogan <73695279+yukogan-gh@users.noreply.github.com>
@come-nc
Copy link
Copy Markdown
Collaborator

come-nc commented Mar 30, 2026

Out of curiosity, could you share which non-string key you had in there?
PHP will autoconvert int-looking like keys into int, so I guess that’s what happened.

@come-nc come-nc merged commit 9607121 into nextcloud:main Mar 31, 2026
50 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants