Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
enhancement
kesselb
approved these changes
Mar 19, 2026
There was a problem hiding this comment.
Pull request overview
Reduces exposure of sensitive OIDC data by removing or sanitizing logging of token/userinfo contents during the login code flow.
Changes:
- Avoid logging full token endpoint responses and parsed JWT payload contents.
- Replace error logging of full response data with logging of response keys only.
- Remove logging of full userinfo values and log userinfo keys instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| $this->logger->debug('Received code response: ' . json_encode($data, JSON_THROW_ON_ERROR)); | ||
| $this->logger->debug('Received code response'); |
| } | ||
|
|
||
| $this->logger->debug('Parsed the JWT payload: ' . json_encode($idTokenPayload, JSON_THROW_ON_ERROR)); | ||
| $this->logger->debug('Parsed the JWT payload'); |
| if (isset($oidcSystemConfig['enrich_login_id_token_with_userinfo']) && $oidcSystemConfig['enrich_login_id_token_with_userinfo']) { | ||
| $userInfo = $this->oidcService->userInfo($provider, $data['access_token']); | ||
| $this->logger->debug('[UserInfoEnrich] Enriching the JWT payload with userinfo values', ['userinfo' => $userInfo]); | ||
| $this->logger->debug('[UserInfoEnrich] Enriching the JWT payload with userinfo values'); |
| if (!isset($idTokenPayload->{$key})) { | ||
| $idTokenPayload->{$key} = $value; | ||
| $this->logger->debug('[UserInfoEnrich] Using userinfo value: ' . $key . ' => ' . $value); | ||
| $this->logger->debug('[UserInfoEnrich] Using userinfo key: ' . $key); |
julien-nc
force-pushed
the
enh/noid/sensitive-logs
branch
2 times, most recently
from
8db7eae to
38092ef
Compare
Member
Author
|
Psalm checks are flaky for some reason. Unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can log ID token (or userinfo) keys but not the values.