Skip to content

Upgrade firebase/php-jwt and adjust implementation#675

Merged
juliusknorr merged 1 commit intomainfrom
enh/upgrade-php-jwt
Aug 30, 2023
Merged

Upgrade firebase/php-jwt and adjust implementation#675
juliusknorr merged 1 commit intomainfrom
enh/upgrade-php-jwt

Conversation

@julien-nc
Copy link
Copy Markdown
Member

  • use latest firebase/php-jwt
  • bump min NC version to 24 to drop php 7.3 support to be able to use recent firebase/php-jwt
  • adjust parameters to jwt::decode

@julien-nc julien-nc requested a review from juliusknorr as a code owner August 30, 2023 11:38
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/upgrade-php-jwt branch from 8776abd to f7b68dd Compare August 30, 2023 11:50
@julien-nc
Copy link
Copy Markdown
Member Author

julien-nc commented Aug 30, 2023

I don't know where the php7.3 check come from 😁

@juliusknorr
Copy link
Copy Markdown
Member

Still a requirement from branch protection, we can remove that then :)

@juliusknorr juliusknorr merged commit d92fe87 into main Aug 30, 2023
@juliusknorr juliusknorr deleted the enh/upgrade-php-jwt branch August 30, 2023 13:49
@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants