fix: Avoid redirecting to login with an incomplete configuration#1091
Merged
fix: Avoid redirecting to login with an incomplete configuration#1091
Conversation
Contributor
come-nc
commented
Apr 30, 2026
come-nc
commented
- Fix Handle incomplete saml configuration more gracefully #840
come-nc
force-pushed
the
fix/avoid-crash-with-incomplete-configuration
branch
from
a61ddf6 to
53c26b1
Compare
CarlSchwan
approved these changes
Apr 30, 2026
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
psalm need a bit of fixing but looks good
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/avoid-crash-with-incomplete-configuration
branch
from
53c26b1 to
3c2857e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.