Add integration test for Environment Variable#78
Merged
LukasReschke merged 1 commit intomasterfrom Jan 19, 2017
Merged
Conversation
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
added a commit
that referenced
this pull request
Jan 19, 2017
Stable11 of #78 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobke
approved these changes
Jan 19, 2017
LukasReschke
deleted the
add-integration-test-for-environment-variable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds integration tests for the environment variable authentication method and also fixes an issue with the Environment Variable auth where the account was setup too early and thus the account couldn't login effectively. (as the SAML app believed the user was already logged-in)
The integration tests should cover these stuff for the future.
Signed-off-by: Lukas Reschke lukas@statuscode.ch