fix(sync): replace non-image or very large screenshots with warning images#19
Open
edward-ly wants to merge 3 commits into
Open
fix(sync): replace non-image or very large screenshots with warning images#19edward-ly wants to merge 3 commits into
edward-ly wants to merge 3 commits into
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
…mages Signed-off-by: Edward Ly <contact@edward.ly>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with some minor refactoring, this PR validates data downloaded from the screenshot URLs in every app's
info.xml, ensuring that every screenshot actually consists of image data. We also now impose a 10MB limit on every screenshot. An auto-generated image replaces every screenshot that is either not recognized as an image (e.g. 404 Not Found) or too large in size.Example images:
