Skip to content

Decouple PushersService

Choose a tag to compare

View all tags
@yakari007 yakari007 released this 18 May 18:59
· 9 commits to master since this release
v1.18.2
d69c596
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Summary

PushersService::trigger() now creates the PusherLog (status=pending) and explicitly dispatches PushObjectJob — no longer relies on the created:NextDeveloper\Commons\PusherLogs event
Removed PushObjectJob::EVENTS constant — the job is no longer event-driven
Removed the status='processing' workaround and synchronous execute() call from trigger()

Why: Architecturally, a log creation event should not trigger its own delivery. The trigger point is PushersService::trigger(), not the DB write. The event-based binding was already commented out in BindEventsCommand.php with the note: "A Log cannot trigger an object. Object can create a log."
Test plan

Call PushersService::trigger($pusherId, $payload) and verify PushObjectJob is dispatched to the commons queue
Confirm the job executes the correct driver and the log transitions from pending → completed/failed
Verify no double-execution occurs

🤖 Generated with Claude Code

Assets 2
Loading