Rename publishPlugin to releasePlugin and remove GitHub publishing #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the releasePlugin task to publishPlugin for consistency with other plugin-specific publishing tasks like publishPluginToRegistry and publishPluginToGithub. This also avoids potential conflicts with the generic 'publish' task from the maven-publish plugin. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add comprehensive Spock tests validating publishPlugin task behavior - Test task registration with different publishing configurations - Test task dependencies for registry and GitHub publishing - Test task is not created when no publishing is configured - Add required test dependencies (Spock framework) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove GitHub publishing tasks (generateGithubMeta, publishPluginToGithub, updateGithubIndex) - Remove GitHub-related imports from NextflowPlugin.groovy - Delete entire github/ directory with all GitHub publishing classes - Update PluginPublishConfig to remove GitHub configuration - Remove GitHub-related test cases from NextflowPluginTest - Now only supports registry publishing via publishPluginToRegistry task 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Ouch, I wanted to make a separate PR for removing the Github related tasks, but Claude was too fast (!) |
pditommaso
changed the title
bentsherman
approved these changes
Jul 29, 2025
Member
bentsherman
left a comment
bentsherman
left a comment
There was a problem hiding this comment.
Let's also update the Makefile in nf-plugin-template to be make publish instead of make release. Maybe make release would still be useful to simply create a github release
Member
Author
|
This made me realise the |
- Rename publishPlugin -> releasePlugin - Rename publishPluginToRegistry -> releasePluginToRegistry - Update task descriptions to use proper capitalization - Update all tests and documentation references 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
pditommaso
changed the title
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename publishPlugin task back to releasePlugin
Summary
publishPlugintask back toreleasePluginto better reflect its purposepublishPluginToRegistrytoreleasePluginToRegistryfor consistencyChanges Made
Task Rename (Latest Update)
publishPlugin→releasePluginto better reflect the tasks purpose of releasing/deploying pluginspublishPluginToRegistry→releasePluginToRegistryfor naming consistencyPrevious Changes
Current Functionality
releasePluginToRegistry- Releases plugin to plugin registryreleasePlugin- Aggregate task for all configured release destinationsnextflowPlugin.publishing.registryTest Plan
releasePlugintask is properly registeredreleasePluginToRegistrytask dependencies are correct